QFE: disable double compression middleware #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
feat/qfe-disable-double-zip-middleware
branch
3 times, most recently
from
7b0ac9a to
e293ae8
Compare
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
feat/qfe-disable-double-zip-middleware
branch
from
e293ae8 to
21dbac5
Compare
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the Zip middleware from the main setup of the QFE, since we already have a compression middleware controlled by the flag
query-frontend.compress-responses.The other gzip middleware is added here: https://github.com/pedro-stanaka/thanos/blob/21dbac558b3f011f530e31fca2dc0607af8ab122/cmd/thanos/query_frontend.go#L324-L328
Verification
Ran the QFE locally, but we are running this on our staging environment and it still returns gzipped responses.