*: Fix issue #7550 - Check correct error when opening rule files in tools #7552
Conversation
|
Hey, Please review the changes and suggest potential improvements. Thanks! |
NishantBansal2003
force-pushed
the
bugfix/fix-and-test-tools
branch
from
e7e6861 to
2f7095b
Compare
|
Hey @saswatamcode, Could you please review this PR and suggest potential improvements? Thank you! |
NishantBansal2003
changed the title
…s.go Signed-off-by: Nishant Bansal <nishant.bansal.mec21@iitbhu.ac.in>
NishantBansal2003
force-pushed
the
bugfix/fix-and-test-tools
branch
from
29854d6 to
05b39c1
Compare
| @@ -55,7 +55,6 @@ func checkRulesFiles(logger log.Logger, patterns *[]string) error { | |||
| if err != nil || matches == nil { | |||
| err = errors.New("matching file not found") | |||
| level.Error(logger).Log("result", "FAILED", "error", err) | |||
| level.Info(logger).Log() | |||
There was a problem hiding this comment.
These are just empty logs, Its output is - level=info, So I removed all level.Info(logger).Log()
There was a problem hiding this comment.
I think it might be intended to leave some spaces between lines.
There was a problem hiding this comment.
Ok, Should I reintroduce all instances of level.Info(logger).Log() throughout the tools.go, or only in this specific part(line 58) of the code?
There was a problem hiding this comment.
I don't have strong preference. I am ok either way to keep them or remove them.
|
Hey @saswatamcode, |
…s.go (thanos-io#7552) Signed-off-by: Nishant Bansal <nishant.bansal.mec21@iitbhu.ac.in>
Changes
Fixes #7550
There is a bug in this part of the code. If there is an issue with opening the file through
os.Open(), we will not be able to obtain exact error logs for debugging. It should return error logs in case there is an issue withos.Open().So, I fixed this bug and added test coverage.
Verification
Run the Tests: Execute the following command to run the tests and verify that the bug has been fixed and the new tests are functioning correctly:
Check Test Results: Ensure that all tests pass and that there are no error messages related to the issue with os.Open()