query,store: Improve replica flag handling #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a string utility parsing function to improve the handling of replica label flags. This allows for easier handling of flags when multiple replica labels are need. * Split flag parts that are comma separated. * Remove any empty strings. * Sort and deduplicate the slice. For example in the case of multiple replica labels like: `--query.replica-label=prometheus_replica,thanos_rule_replica` Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/flag_labels
branch
from
34717b9 to
050f014
Compare
SuperQ
changed the title
saswatamcode
approved these changes
Oct 28, 2024
|
Yes, I also prefer repeatable flags. But when using Kustomize templates we're a bit stuck with having to use a single flag with variable substitution. |
pedro-stanaka
pushed a commit
to pedro-stanaka/thanos
that referenced
this pull request
Oct 31, 2024
Add a string utility parsing function to improve the handling of replica label flags. This allows for easier handling of flags when multiple replica labels are need. * Split flag parts that are comma separated. * Remove any empty strings. * Sort and deduplicate the slice. For example in the case of multiple replica labels like: `--query.replica-label=prometheus_replica,thanos_rule_replica` Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a string utility parsing function to improve the handling of replica label flags. This allows for easier handling of flags when multiple replica labels are need.
For example in the case of multiple replica labels like:
--query.replica-label=prometheus_replica,thanos_rule_replicaVerification