Add counter cache for good/bad events.

app/models/bad_event.rb

@@ -1,4 +1,4 @@
 class BadEvent < ApplicationRecord
   has_many :user_bad_events, dependent: :destroy
-  has_many :users, through: :user_bad_events
+  has_many :users, through: :user_bad_events, counter_cache: true
 end

app/models/good_event.rb

@@ -1,4 +1,4 @@
 class GoodEvent < ApplicationRecord
   has_many :user_good_events, dependent: :destroy
-  has_many :users, through: :user_good_events
+  has_many :users, through: :user_good_events, counter_cache: true
 end

app/models/user.rb

@@ -9,9 +9,9 @@ class User < ApplicationRecord
   has_many :user_job_roles, dependent: :destroy
   has_many :job_roles, through: :user_job_roles
   has_many :user_good_events, dependent: :destroy
-  has_many :good_events, through: :user_good_events
+  has_many :good_events, through: :user_good_events, counter_cache: true
   has_many :user_bad_events, dependent: :destroy
-  has_many :bad_events, through: :user_bad_events
+  has_many :bad_events, through: :user_bad_events, counter_cache: true
 
   normalizes :email, with: ->(email) { email.downcase.strip }
 

db/migrate/20241115082525_add_users_count_to_bad_events.rb

@@ -0,0 +1,8 @@
+class AddUsersCountToBadEvents < ActiveRecord::Migration[8.0]
+  def change
+    add_column :bad_events, :users_count, :integer, null: false, default: 0
+    add_column :good_events, :users_count, :integer, null: false, default: 0
+    add_column :users, :good_events_count, :integer, null: false, default: 0
+    add_column :users, :bad_events_count, :integer, null: false, default: 0
+  end
+end

lib/tasks/maintain.rake

@@ -0,0 +1,15 @@
+namespace :maintain do
+  desc "Reset counters"
+  task reset_counters: :environment do
+    BadEvent.find_each do |bad_event|
+      BadEvent.reset_counters(bad_event.id, :users) if bad_event.users.present?
+    end
+    GoodEvent.find_each do |good_event|
+      GoodEvent.reset_counters(good_event.id, :users) if good_event.users.present?
+    end
+    User.find_each do |user|
+      User.reset_counters(user.id, :bad_events) if user.bad_events.present?
+      User.reset_counters(user.id, :good_events) if user.good_events.present?
+    end
+  end
+end

test/fixtures/bad_events.yml

@@ -1,6 +1,8 @@
 ---
 bad_one:
   bad_title: "Bad things title"
+  users_count: 1
 
 worse_two:
   bad_title: "Worse things title"
+  users_count: 2

test/fixtures/good_events.yml

@@ -1,6 +1,8 @@
 ---
 good_one:
   good_title: "Good things title"
+  users_count: 2
 
 great_two:
   good_title: "Great things title"
+  users_count: 1

test/fixtures/users.yml

@@ -9,9 +9,13 @@ user_guochunzhong:
   chinese_name: "过纯中"
   hire_date: "2019-03-04"
   clerk_code: "015454"
+  bad_events_count: 2
+  good_events_count: 1
 
 user_fangzixue:
   email: fangzixue@thape.com.cn
   chinese_name: "方子雪"
   hire_date: "2018-07-23"
   clerk_code: "013771"
+  bad_events_count: 1
+  good_events_count: 2

test/models/bad_event_test.rb

@@ -5,11 +5,13 @@ class BadEventTest < ActiveSupport::TestCase
     bad_one = bad_events(:bad_one)
     assert bad_one.valid?
     assert_equal bad_one.users.count, 1
+    assert_equal bad_one.users_count, 1
   end
 
   test "Worse two has 2 users" do
     worse_two = bad_events(:worse_two)
     assert worse_two.valid?
     assert_equal worse_two.users.count, 2
+    assert_equal worse_two.users_count, 2
   end
 end

test/models/good_event_test.rb

@@ -5,11 +5,13 @@ class GoodEventTest < ActiveSupport::TestCase
     good_one = good_events(:good_one)
     assert good_one.valid?
     assert_equal good_one.users.count, 2
+    assert_equal good_one.users_count, 2
   end
 
   test "Good two has 1 user" do
     great_two = good_events(:great_two)
     assert great_two.valid?
     assert_equal great_two.users.count, 1
+    assert_equal great_two.users_count, 1
   end
 end

test/models/user_test.rb

@@ -5,23 +5,27 @@ class UserTest < ActiveSupport::TestCase
     guochunzhong = users(:user_guochunzhong)
     assert guochunzhong.valid?
     assert_equal guochunzhong.bad_events.count, 2
+    assert_equal guochunzhong.bad_events_count, 2
   end
 
   test "User user_fangzixue has 1 record of bad_events" do
     fangzixue = users(:user_fangzixue)
     assert fangzixue.valid?
     assert_equal fangzixue.bad_events.count, 1
+    assert_equal fangzixue.bad_events_count, 1
   end
 
   test "User guochunzhong has 1 record of good_events" do
     guochunzhong = users(:user_guochunzhong)
     assert guochunzhong.valid?
     assert_equal guochunzhong.good_events.count, 1
+    assert_equal guochunzhong.good_events_count, 1
   end
 
   test "User user_fangzixue has 2 record of good_events" do
     fangzixue = users(:user_fangzixue)
     assert fangzixue.valid?
     assert_equal fangzixue.good_events.count, 2
+    assert_equal fangzixue.good_events_count, 2
   end
 end