Extract the first_level_user_job_roles and views.

thape-cn · Nov 13, 2024 · e134cd5 · e134cd5
1 parent 12c74e3
commit e134cd5
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 24 deletions.
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
@@ -4,6 +4,7 @@ class HomeController < ApplicationController
   before_action :set_breadcrumbs, if: -> { request.format.html? }
 
   def index
+    @first_level_user_job_roles = current_user&.user_job_roles
     redirect_to admin_root_path if current_user&.admin?
   end
 

diff --git a/app/views/home/_user_job_roles.html.erb b/app/views/home/_user_job_roles.html.erb
@@ -0,0 +1,17 @@
+<% user_job_roles.each do |role| %>
+  <h4><%= role.title %> <small class="text-muted float-end"><%= role.company %></small></h4>
+  <div class="row">
+    <% role.managed_user_job_roles.each do |role| %>
+      <div class="col-3">
+        <div class="card my-3">
+          <div class="card-body">
+            <div class="text-center">
+              <div><%= role.user.chinese_name %></div>
+              <small class="text-muted"><%= role.title %></small>
+            </div>
+          </div>
+        </div>
+      </div>
+    <% end %>
+  </div>
+<% end %>
diff --git a/app/views/home/index.html.erb b/app/views/home/index.html.erb
@@ -4,28 +4,12 @@
 
 <%= render 'login_button' unless current_user.present? %>
 
-<section class="container mt-4">
-  <div class="row">
-    <div class="col-12">
-      <% if current_user&.user_job_roles&.present? %>
-        <% current_user.user_job_roles.each do |role| %>
-          <h4><%= role.title %> <small class="text-muted float-end"><%= role.company %></small></h4>
-          <div class="row">
-            <% role.managed_user_job_roles.each do |role| %>
-              <div class="col-3">
-                <div class="card my-3">
-                  <div class="card-body">
-                    <div class="text-center">
-                      <div><%= role.user.chinese_name %></div>
-                      <small class="text-muted"><%= role.title %></small>
-                    </div>
-                  </div>
-                </div>
-              </div>
-            <% end %>
-          </div>
-        <% end %>
-      <% end %>
+<% if @first_level_user_job_roles.present? %>
+  <section class="container mt-4">
+    <div class="row">
+      <div class="col-12">
+        <%= render partial: 'user_job_roles', locals: { user_job_roles: @first_level_user_job_roles } %>
+      </div>
     </div>
-  </div>
-</section>
+  </section>
+<% end %>