Avoid delegate allocation in TraceSourceLoggerProvider.GetOrAddTraceS…

…ource (dotnet#71134) Every call to GetOrAddTraceSource was allocating a new delegate instance.
thaystg · Jun 22, 2022 · de078d1 · de078d1
1 parent c1d4494
commit de078d1
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/libraries/Microsoft.Extensions.Logging.TraceSource/src/TraceSourceLoggerProvider.cs b/src/libraries/Microsoft.Extensions.Logging.TraceSource/src/TraceSourceLoggerProvider.cs
@@ -53,10 +53,9 @@ public ILogger CreateLogger(string name)
             return new TraceSourceLogger(GetOrAddTraceSource(name));
         }
 
-        private DiagnosticsTraceSource GetOrAddTraceSource(string name)
-        {
-            return _sources.GetOrAdd(name, InitializeTraceSource);
-        }
+        private DiagnosticsTraceSource GetOrAddTraceSource(string name) =>
+            _sources.TryGetValue(name, out DiagnosticsTraceSource? source) ? source :
+            _sources.GetOrAdd(name, InitializeTraceSource(name));
 
         private DiagnosticsTraceSource InitializeTraceSource(string traceSourceName)
         {