forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
56773 Review on code smell JabRef#11
- Loading branch information
1 parent
e574567
commit 53aa570
Showing
1 changed file
with
11 additions
and
7 deletions.
There are no files selected for viewing
18 changes: 11 additions & 7 deletions
18
Project/Phase 1/Sprint 1/team_member_56971/code_smells_56971_reviewlog.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,18 @@ | ||
Team Member 58625 (Gabriela Costa) | ||
|
||
Regarding the Dead Code code smell (code smell #10) | ||
Regarding the Dead Code code smell (code smell #10) | ||
|
||
"I don't think this can be classified as a case of dead code. This class is used, namely in /src/main/java/org/jabref/logic/autosaveandbackup/AutosaveManager.java, and /src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java. | ||
In the first class, the AutosaveEvent object is used as a parameter to the listen() method, which needs it in order to identify the type of event triggered (in this case, an AutosaveEvent). | ||
In the second class, the AutosaveEvent object allows us to place an event into the event bus to which the listen() method subscribes to. | ||
In short, even though this class is empty, it is not dead code, since it serves a very specific purpose." -19:55 -23/11 | ||
"I don't think this can be classified as a case of dead code. This class is used, namely in /src/main/java/org/jabref/logic/autosaveandbackup/AutosaveManager.java, and /src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java. | ||
In the first class, the AutosaveEvent object is used as a parameter to the listen() method, which needs it in order to identify the type of event triggered (in this case, an AutosaveEvent). | ||
In the second class, the AutosaveEvent object allows us to place an event into the event bus to which the listen() method subscribes to. | ||
In short, even though this class is empty, it is not dead code, since it serves a very specific purpose." -19:55 -23/11 | ||
|
||
Team Member 56971 (João Vieira): | ||
|
||
in response to Team Member 58625 (Gabriela Costa) regarding The Dead Code smell (code smell #10) | ||
in response to Team Member 58625 (Gabriela Costa) regarding The Dead Code smell (code smell #10) | ||
|
||
"I disagree, yes this class is used, I mentioned it my description but the reason I classified this as dead code is that the class is empty and adds no new functionality to the application. Its only purpose is to satisfy verifications, therefore believe this should not exist, at very least it could be something like a interface.A empty class is basically useless" -20:55 -23/11 | ||
"I disagree, yes this class is used, I mentioned it my description but the reason I classified this as dead code is that the class is empty and adds no new functionality to the application. Its only purpose is to satisfy verifications, therefore believe this should not exist, at very least it could be something like a interface.A empty class is basically useless" -20:55 -23/11 | ||
|
||
Gonçalo Virgínia (56773): | ||
|
||
Code smell #11 (Duplicated Code): "Sounds good, simple fix." |
53aa570
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message was supposed to be "56773 Review on code smell # 11".