update action to Node 20 and bump packages #18
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll.eslint": true | |||
| "source.fixAll.eslint": "explicit" | |||
There was a problem hiding this comment.
Automatically updated by VSCode, same behaviour as true: https://code.visualstudio.com/docs/typescript/typescript-refactoring#_code-actions-on-save
There was a problem hiding this comment.
Removed this file as is not used from what I can tell. May have been left over from the original action.
There was a problem hiding this comment.
Removed as this version of the action appears to use yarn. Also left over from original action which used npm.
| "@actions/core": "1.10.1", | ||
| "@actions/github": "6.0.0", | ||
| "@typescript-eslint/eslint-plugin": "7.7.0", | ||
| "@typescript-eslint/parser": "7.7.0", | ||
| "@vercel/ncc": "0.38.1", | ||
| "eslint": "8.57.0", | ||
| "typescript": "5.4.5" |
There was a problem hiding this comment.
All of these have been updated to their latest versions.
The exception is eslint which is has been updated to latest 8. This is the only package which I think may have large breaking changes.
Should also note that the master branch currently has a lot of eslint errors, probably allowed to be merge due to no automated testing.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "workflow-dispatch-and-wait", | |||
| "version": "3.0.0", | |||
| "version": "4.0.0", | |||
There was a problem hiding this comment.
Most actions have seen have treated going from Node 16 to Node 20 as a breaking change.
|
Hi @aurelien-baudet, would you be able to review? |
|
@Djontleman given this repo looks abandoned, could you tag this in your repo as |
|
I have created |
|
Sorry, I have no more time and energy to maintain this repository. I even don't have computer anymore. Someone of you should for this repository and merge the different pull requests. |
|
@Djontleman I wanted to know if you're planning to take over on this action. |
|
Hi @fbiesse I don't plan to maintain this. I'm happy for you to if you're up for it. |
|
Hi, FYI benc-uk#73 |
Problem
Node 16 actions are deprecated. This action should be updated to Node 20.
Changes
## Testing
Tested in my own fork after merging the same changes (Djontleman#1).
Workflow run: https://github.com/Djontleman/workflow-dispatch/actions/runs/8785890431