Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signature editor form is submitted on menu open #1498

Merged

Conversation

SergeyMosin
Copy link

Set menu button element 'type' property to 'button', otherwise Signature Editor closes(wrapper form is submitted) when one of the drop-down menus is open.

@the-djmaze the-djmaze merged commit 8f417c5 into the-djmaze:master Mar 15, 2024
1 check passed
the-djmaze pushed a commit that referenced this pull request Mar 19, 2024
@the-djmaze
Copy link
Owner

the-djmaze commented Mar 19, 2024

@SergeyMosin i've modified your extension a bit.
It didn't support older Firefox and Safari due to the # private.

I also changed something how you can modify the DOM without the need of PopupsCompactCompose.html

Take a look at it (i marked it as 1.0.3-beta)

@the-djmaze the-djmaze added bug Something isn't working extensions (plugin) labels Mar 19, 2024
@SergeyMosin
Copy link
Author

SergeyMosin commented Mar 20, 2024

@the-djmaze The new code looks good to me. Thank you.

the-djmaze pushed a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extensions (plugin)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants