Enable corepack & fix pre-commit run --all-files
#462
Conversation
| @@ -0,0 +1 @@ | |||
| nodeLinker: node-modules | |||
There was a problem hiding this comment.
Specifying pnpm here might conserve disk space
…pack more At least yarn build didn't break locally for me, so I think it's supported here too
|
Additionally it's not necessary to call It's inspired by https://github.com/nodejs/corepack/blob/v0.28.2/README.md#corepack-enable--name |
|
Scimming through the CI logs it seems that it's unable to find Draupnir version, which I think is related to this I think that needs actual coder to check it thogh. |
|
Yeah that's a known issue and unrelated to this PR, don't worry about it |
|
@Mikaela did you follow https://yarnpkg.com/migration/guide ? |
| @@ -77,5 +77,6 @@ | |||
| }, | |||
| "engines": { | |||
| "node": ">=18.0.0" | |||
| } | |||
| }, | |||
| "packageManager": "yarn@4.3.1+sha512.af78262d7d125afbfeed740602ace8c5e4405cd7f4735c08feb327286b2fdb2390fbca01589bfd1f50b1240548b74806767f5a063c94b67e431aabd0d86f7774" | |||
There was a problem hiding this comment.
It is what corepack use yarn gave me
|
More or less, although by accident |
|
oki |
|
Been playing around with yarn4 just to make sure everything is in order, unfortunately I haven't been able to get https://classic.yarnpkg.com/lang/en/docs/cli/link/ I'm investigating this but it might take awhile. |
|
Ok, that looks promising. However, seems like projects that have been touched by yarn classic aren't automatically migrated to use "yarn plug'n'play" which is required for the editor integration. https://yarnpkg.com/migration/pnp. |
Briefly talked on Matrix, I think the project was previously using an old yarn version since there was a warning about the project being updated to new yarn version when I ran
corepack use yarn.I don't know if this brings breaking changes and I am curious on whether the tests or CI pass.