Rename to Draupnir in Appropriate Places #591
Conversation
| @@ -21,5 +21,5 @@ ENV NODE_ENV=production | |||
| ENV NODE_CONFIG_DIR=/data/config | |||
|
|
|||
| CMD ["bot"] | |||
| ENTRYPOINT ["./mjolnir-entrypoint.sh"] | |||
| ENTRYPOINT ["./draupnir-entrypoint.sh"] | |||
There was a problem hiding this comment.
I'd prefer to be conservative about changing this, just in case someone else has built their own image based on our own.
There was a problem hiding this comment.
You do make a fair point about this. But i also do think that we should break this at some point as we should remove all references to mjolnir from the codebase that are not historical references.
As in if we refer to mjolnir it should be like for example refering to a Mjolnir issue or that this file integrates work from mjolnir.
There was a problem hiding this comment.
But i also do think that we should break this at some point as we should remove all references to mjolnir from the codebase that are not historical references.
Why?
There was a problem hiding this comment.
it gives a certain vibe to some people that we refer to our selfs as mjolnir all over the place. This PR should hopefully reduce the chances of end users seeing us call our selfs mjolnir in logs or via command errors.
|
Willing to give this the all clear, @MTRNord, do you have any thoughts before we merge this? |
FSG-Cat
force-pushed
the
FSG-Cat/Draupnir-Rename
branch
from
5bb9b82 to
8516743
Compare
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [Unreleased] - 2024-10-04 |
There was a problem hiding this comment.
@FSG-Cat you didn't write anything
CHANGELOG.md
Outdated
| Entrypoint was renamed from `mjolnir-entrypoint.sh` to `draupnir-entrypoint.sh` | ||
|
|
||
| `mjolnir-registration.yaml` was renamed to `draupnir-registration.yaml` this change should not have any end user impact. |
There was a problem hiding this comment.
You should have wrote this in the unreleased part and follow the convention that is laid out in https://keepachangelog.com/en/1.1.0/
CHANGELOG.md
Outdated
| ## [Unreleased] - 2024-10-04 | ||
|
|
||
| ### Versions v2.0.0-beta.7 and prior | ||
|
|
||
| Entrypoint was renamed from `mjolnir-entrypoint.sh` to `draupnir-entrypoint.sh` | ||
|
|
||
| `mjolnir-registration.yaml` was renamed to `draupnir-registration.yaml` this change should not have any end user impact. | ||
|
|
||
| Please see [Releases](https://github.com/the-draupnir-project/Draupnir/releases) for more information. |
There was a problem hiding this comment.
| ## [Unreleased] - 2024-10-04 | |
| ### Versions v2.0.0-beta.7 and prior | |
| Entrypoint was renamed from `mjolnir-entrypoint.sh` to `draupnir-entrypoint.sh` | |
| `mjolnir-registration.yaml` was renamed to `draupnir-registration.yaml` this change should not have any end user impact. | |
| Please see [Releases](https://github.com/the-draupnir-project/Draupnir/releases) for more information. | |
| ## [Unreleased] - 2024-10-04 | |
| ### Changed | |
| * `Dockerfile`: entry-point was renamed from `mjolnir-entrypoint.sh` to `draupnir-entrypoint.sh`. If you have built a Dockerfile based on ours, you may need to make some changes. | |
| * `Dockerfile`: source code was moved from `/mjolnir` to `/draupnir`. If you have built a custom docker image based on our Dockerfile based on ours, you may need to make some changes. | |
| * The appservice registration file generator no longer emits `mjolnir-registration.yaml` as it has been renamed to `draupnir-registration.yaml`. This is only a concern if you have automated tooling that generates a registration file. | |
| ## Versions v2.0.0-beta.7 and prior | |
| Please see https://github.com/the-draupnir-project/Draupnir/releases for more information. |
This PR aims to make it so its harder to find places where the bot calls it self Mjolnir without it affecting code in ways that i cant begin to predict.