Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove References to Regex in Config Example as they are false #600

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

FSG-Cat
Copy link
Member

@FSG-Cat FSG-Cat commented Oct 6, 2024

Regex is not supported by wordlist protection so lets strip the references.

@FSG-Cat FSG-Cat added L3 Some Users Likelihood P2 Aggravating Priority level T2 Rendering or Aesthetic Issue Visual and Sound Polish: Aesthetic issues labels Oct 6, 2024
@FSG-Cat FSG-Cat requested a review from Gnuxie October 6, 2024 09:03
Comment on lines -188 to -191
# For advanced usage, regex can also be used, see the following links for more information;
# - https://www.digitalocean.com/community/tutorials/an-introduction-to-regular-expressions
# - https://regexr.com/
# - https://regexone.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably explicitly say that they don't support regexs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow thats a sensible change but im not sure how you would like it to be worded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word list protection does not support regular expressions at this time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording added.

@Gnuxie Gnuxie self-requested a review October 9, 2024 11:42
@Gnuxie Gnuxie merged commit 54dd85d into the-draupnir-project:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L3 Some Users Likelihood P2 Aggravating Priority level T2 Rendering or Aesthetic Issue Visual and Sound Polish: Aesthetic issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants