Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubocop #12

Merged
merged 7 commits into from
Jan 29, 2023
Merged

Add Rubocop #12

merged 7 commits into from
Jan 29, 2023

Conversation

the-teacher
Copy link
Owner

@the-teacher the-teacher commented Jan 29, 2023

In this PR I add rubocop to provide quality of the code.

  • I found that adding # frozen_string_literal: true is still good practice in Ruby3/Rails7 Link
    I do not actually like that # frozen_string_literal: true affected default rails files. But no problem.
  • I found new syntax content_raw:
  • I had to review files to decide what files to exclude from checks. I wanted to avoid some checks of default rails files, also decided to avoid some checks for file that I've created for the project.

Screenshot 2023-01-29 at 15 06 02

Screenshot 2023-01-29 at 10 12 27

@the-teacher the-teacher merged commit 1265064 into master Jan 29, 2023
@the-teacher the-teacher deleted the rubocop branch September 17, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant