New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the GHS.XLS #1567

Merged

yiancar merged 2 commits into the-via:master from ramonimbao:ghs_xls

Dec 27, 2022

Contributor

ramonimbao commented Dec 13, 2022

Description

Adds the GHS.XLS.

QMK Pull Request

qmk/qmk_firmware#19185

Checklist

The VIA support for this keyboard is in QMK master already (MANDATORY)
The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
I have tested this keyboard definition using VIA's "Design" tab.
I have tested this keyboard definition with firmware on a device.
I have assigned alpha keys and modifier keys with the correct colors.
The Vendor ID is not 0xFEED


          Add the GHS.XLS

aaff61b

Collaborator

yiancar commented Dec 20, 2022

Hello, please also add a v3 definition as v2 is being superseeded and can no longer be used by newer QMK firmware.

yiancar added the blocked label


          Add V3 definition for GHS.XLS

98691ed

Contributor Author

ramonimbao commented Dec 22, 2022

Sorry about that. Added, and should be okay now.

Collaborator

yiancar commented Dec 27, 2022

Cheers thanks:)

yiancar merged commit 14813c9 into the-via:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels