Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for Tinyneko/Eclipse60 #1694

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Add VIA support for Tinyneko/Eclipse60 #1694

merged 3 commits into from
Feb 14, 2023

Conversation

MaiTheSan
Copy link
Contributor

@MaiTheSan MaiTheSan commented Feb 14, 2023 •
edited
Loading

Description

Add support for eclipse60/tinyneko

QMK Pull Request

qmk/qmk_firmware#19379

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@MaiTheSan MaiTheSan changed the title Tinyneko/Eclipse60 Add VIA support for Tinyneko/Eclipse60 Feb 14, 2023
@yiancar
Copy link
Collaborator

yiancar commented Feb 14, 2023

Can you please add V3 Jsons as well?

@MaiTheSan
Copy link
Contributor Author

Can you please add V3 Jsons as well?

yes

@yiancar
Copy link
Collaborator

yiancar commented Feb 14, 2023

Cheers thanks!

@yiancar yiancar merged commit 310f1f4 into the-via:master Feb 14, 2023
@MaiTheSan
Copy link
Contributor Author

thanks~

@MaiTheSan MaiTheSan deleted the SalaneBranch branch February 15, 2023 11:12
@MaiTheSan MaiTheSan restored the SalaneBranch branch February 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaiTheSan @yiancar