-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #1712
Add files via upload #1712
Conversation
JSON for Reviung34 by gtips.
Please fix PR comments and formatting. |
Hello. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing the three changes I've suggested will add the missing alternate layout.
The original text you labeled this pull request with. Look at other pull requests like #1708 -- there are checkboxes instead of list markers, and a QMK pull request linked under the "QMK Pull Request" header. Use the "Preview" tab to see what your message will look like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
Hello. |
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Hi please move from |
So, I should move reviung34 folder from /src to /v3 and commit this change, right? |
Yes |
Moving form /src to /v3.
Deleting folder from /src.
Done. |
JSON for Reviung34 by gtips.
Description
QMK Pull Request
qmk/qmk_firmware#19694
Checklist
0xFEED