Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #1712

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Add files via upload #1712

merged 6 commits into from
Feb 28, 2023

Conversation

azhizhinov
Copy link
Contributor

@azhizhinov azhizhinov commented Feb 24, 2023

JSON for Reviung34 by gtips.

Description

QMK Pull Request

qmk/qmk_firmware#19694

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

JSON for Reviung34 by gtips.
@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 27, 2023

Please fix PR comments and formatting.
Please add QMK link

@azhizhinov
Copy link
Contributor Author

Hello.
Sorry, I'm not experienced enough in this kind of things, so adding link here.
https://github.com/qmk/qmk_firmware/tree/master/keyboards/reviung/reviung34/keymaps/via
Where I should fix formatting?
Thanks for your time.

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing the three changes I've suggested will add the missing alternate layout.

src/reviung34/reviung34.json Outdated Show resolved Hide resolved
src/reviung34/reviung34.json Outdated Show resolved Hide resolved
src/reviung34/reviung34.json Outdated Show resolved Hide resolved
@lesshonor
Copy link
Contributor

Hello. Sorry, I'm not experienced enough in this kind of things, so adding link here. https://github.com/qmk/qmk_firmware/tree/master/keyboards/reviung/reviung34/keymaps/via Where I should fix formatting? Thanks for your time.

The original text you labeled this pull request with. Look at other pull requests like #1708 -- there are checkboxes instead of list markers, and a QMK pull request linked under the "QMK Pull Request" header. Use the "Preview" tab to see what your message will look like.

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/quickstart-for-writing-on-github

Copy link
Contributor Author

@azhizhinov azhizhinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@azhizhinov
Copy link
Contributor Author

Hello.
Mostly done, I hope.
Thanks in advance.

azhizhinov and others added 3 commits February 28, 2023 10:54
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 28, 2023

Hi please move from src/ folder to v3/ folder (seems the check is failing due to this)

@azhizhinov
Copy link
Contributor Author

Hi please move from src/ folder to v3/ folder (seems the check is failing due to this)

So, I should move reviung34 folder from /src to /v3 and commit this change, right?

@Xelus22
Copy link
Collaborator

Xelus22 commented Feb 28, 2023

Yes

Moving form /src to /v3.
Deleting folder from /src.
@azhizhinov
Copy link
Contributor Author

Done.

@Xelus22 Xelus22 merged commit 4ae2234 into the-via:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants