Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add support for Pierce split keyboard #1747

Merged
merged 2 commits into from
Mar 24, 2023
Merged

[Keyboard] Add support for Pierce split keyboard #1747

merged 2 commits into from
Mar 24, 2023

Conversation

azhizhinov
Copy link
Contributor

@azhizhinov azhizhinov commented Mar 11, 2023 •
edited
Loading

/v3/pierce/pierce.json

Description

Add support for Pierce split keyboard

QMK Pull Request

qmk/qmk_firmware#20045

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Mar 24, 2023

Just making sure that you have no accents? Everything is an alpha? no modifiers/accents?

@azhizhinov
Set key color #777777 for accents.
476944c 
Set key color #777777 for accents (i.e. Esc, Enter, arrows, etc).
@azhizhinov
Copy link
Contributor Author

Hello. @Xelus22
Thanks for your time.
Has set #777777 for accents (i.e. Esc, Enter, arrows, etc).

@Xelus22 Xelus22 merged commit 21df5ca into the-via:master Mar 24, 2023
@azhizhinov azhizhinov mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azhizhinov @Xelus22