Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Coban Pad 3A #1778

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Add support for Coban Pad 3A #1778

merged 3 commits into from
Mar 24, 2023

Conversation

RyanDam
Copy link
Contributor

@RyanDam RyanDam commented Mar 22, 2023

Description

Coban Pad 3A

Add new keyboard: Coban Pad 3A.
Coban Pad 3A is small macro keyboard with 2 hotswapable button and 1 EC11 rotary encoder

Note: I original created PR #1653 but it is closed due to my PR to QMK is not merged. Now it is merged.

QMK Pull Request

qmk/qmk_firmware#19634

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Mar 24, 2023

Is there any legacy pcbs with V2? As this has just been merged. (we're trying to not add anything to V2 moving forward unless in extreme circumstances). If not please remove the V2 (src folder) defintion.

@RyanDam
Copy link
Contributor Author

RyanDam commented Mar 24, 2023

Is there any legacy pcbs with V2? As this has just been merged. (we're trying to not add anything to V2 moving forward unless in extreme circumstances). If not please remove the V2 (src folder) defintion.

@Xelus22 I'm not aware that V2 is deprecated, now V2 is deleted.

@Xelus22 Xelus22 merged commit a782997 into the-via:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants