Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for LXXT pcb #1817

Closed
wants to merge 2 commits into from
Closed

Added support for LXXT pcb #1817

wants to merge 2 commits into from

Conversation

DeskDaily
Copy link
Contributor

Description

QMK Pull Request

qmk/qmk_firmware#19935

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Apr 22, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Remove V2 (src/ folder) definition as this is only for legacy support.

@DeskDaily
Copy link
Contributor Author

Please Remove V2 (src/ folder) definition as this is only for legacy support.

alright. thank you Xelus22

Xelus22
Xelus22 requested changes May 13, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your failing CI please

@DeskDaily DeskDaily closed this May 22, 2023
@DeskDaily DeskDaily deleted the lxxt branch May 22, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeskDaily @Xelus22