Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7U support for creek70 #1830

Merged
merged 10 commits into from
Apr 24, 2023
Merged

Add 7U support for creek70 #1830

merged 10 commits into from
Apr 24, 2023

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Apr 16, 2023

Description

image

CleanShot 2023-04-16 at 06 25 51@2x

QMK Pull Request

qmk/qmk_firmware#19789

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@spbgzh
Copy link
Contributor Author

spbgzh commented Apr 16, 2023

It dont need to change anything in fireware because, it use same postions.
CleanShot 2023-04-16 at 19 13 23@2x

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you renaming Creek 70 to Epiphany 70? You will need to submit a new keyboard to QMK if you are adding a new keyboard.

@spbgzh spbgzh requested a review from Xelus22 April 22, 2023 15:25
@spbgzh
Copy link
Contributor Author

spbgzh commented Apr 22, 2023

I want to change name of keyboard, I will make a new PR to change keyboard's name @Xelus22

@Xelus22 Xelus22 merged commit da01b9e into the-via:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants