Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add egg58 keyboard #1890

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Add egg58 keyboard #1890

merged 1 commit into from
Jun 11, 2023

Conversation

tmick0
Copy link
Contributor

@tmick0 tmick0 commented Jun 4, 2023 •
edited
Loading

Description

Adds support for the egg58

QMK Pull Request

qmk/qmk_firmware#21021

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@tmick0 tmick0 marked this pull request as ready for review June 6, 2023 15:29
@Xelus22 Xelus22 merged commit 6aa559e into the-via:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmick0 @Xelus22