Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Adding osav2_numpad.json #1892

Merged
merged 2 commits into from
Jun 11, 2023
Merged

[Keyboard] Adding osav2_numpad.json #1892

merged 2 commits into from
Jun 11, 2023

Conversation

blindassassin111
Copy link
Contributor

Description

Adding support for the mx OSAv2 Numpad.

QMK Pull Request

qmk/qmk_firmware#20209

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22 Xelus22 merged commit e942705 into the-via:master Jun 11, 2023
@blindassassin111 blindassassin111 deleted the osav2_numpad branch June 11, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blindassassin111 @Xelus22