Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pi60 update #1938

Merged
merged 4 commits into from
Jul 15, 2023
Merged

pi60 update #1938

merged 4 commits into from
Jul 15, 2023

Conversation

ziptyze
Copy link
Contributor

@ziptyze ziptyze commented Jul 7, 2023

Small update to the configuration for the pi60.

Description

The next revision of the board includes an option for a 2u left shift, and shifted row. While there is a difference to the PCB, the firmware remains identical so the only update needs to be the via configuration to allow for the new layout.

QMK Pull Request

qmk/qmk_firmware#21404

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except you changed the folder & file name. Please reflect the same QMK tree naming

@ziptyze
Copy link
Contributor Author

ziptyze commented Jul 10, 2023

Everything looks good except you changed the folder & file name. Please reflect the same QMK tree naming

Apologies, we had been in the process internally of updating the naming to be more consistent with 1up coming before all of the product names, but we should update that first on QMK.

I will make the changes to reflect what is currently in the main repo.

@Xelus22 Xelus22 merged commit 306563a into the-via:master Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants