Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new keyboard zoom98 #2025

Closed
wants to merge 1 commit into from
Closed

add new keyboard zoom98 #2025

wants to merge 1 commit into from

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Sep 25, 2023

Description

QMK Pull Request

qmk/qmk_firmware#22062

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Sep 30, 2023
View reviewed changes
v3/meletrix/zoom98/zoom98.json
"vendorId": "0x36B5",
"productId": "0x27D6",
"keycodes": ["qmk_lighting"],
"menus": ["qmk_rgb_matrix"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qmk/qmk_firmware#22120

Please use this as a reference. Your current QMK firmware does not have ALL animations enabled to use qmk_rgb_matrix

@spbgzh spbgzh closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spbgzh @Xelus22