Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ploopyco/madromys #2080

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Add support for ploopyco/madromys #2080

merged 2 commits into from
Jan 1, 2024

Conversation

ploopyco
Copy link
Contributor

Description

Add support for ploopyco/madromys

QMK Pull Request

qmk/qmk_firmware#21989

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use V3 folder. Src folder is no longer getting additions and only for legacy boards.

@ploopyco ploopyco requested a review from Xelus22 November 30, 2023 17:48
@ploopyco ploopyco requested a review from Xelus22 December 12, 2023 17:02
@yiancar yiancar merged commit 79b4f64 into the-via:master Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie left review comments

@Xelus22 Xelus22 Awaiting requested review from Xelus22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ploopyco @Xelus22 @keyboard-magpie @yiancar