Added The Mad Noodle Folder, noodlepad_micro Keypad Definitions and udon13 Keypad Definitions #2131
Conversation
|
Any update on this? |
Added Support for the Udon aswell
jessel92
changed the title
Fully Tested
| "customKeycodes": [ | ||
| { | ||
| "name": "RGB Layer Mode", | ||
| "title": "Toggle the RGB Layer Indicator Mode (Mode1: Blink White=0, Red=1, Green=2, Blue=3) / (Mode2: One LED lit white according to current layer)", | ||
| "shortName": "L_IND" | ||
| }, | ||
| { | ||
| "name": "Cycle Layers", | ||
| "title": "Cycle through the layers (Place on same key on all layers)", | ||
| "shortName": "L_CYC" | ||
| } | ||
| ], |
There was a problem hiding this comment.
I don't see the custom keycodes in the QMK firmware?
There was a problem hiding this comment.
Oh crap! I literally just committed those changes in today totally forgetting that they need to be in the QMK master as well.
I actually just made the PR today for those changes to QMK qmk/qmk_firmware#23003
There was a problem hiding this comment.
@Xelus22 I'd ideally like these changes in there, so should we wait until the QMK PR is merged?
Or should i revert that last commit for now? Or can we just push it through even though they arent in just yet.
The only reason I ask is because im in a bit of rush, since im trying to launch this new keypad ASAP and id like Easy via support on launch.
There was a problem hiding this comment.
You can either:
- remove these and get it merged now
- wait and get it merged when QMK one gets merged.
There was a problem hiding this comment.
@Xelus22 I might wait, at least for the micro. Just because I think it'll make a difference for my customers.
If I do wait though, I don't really want to have to wait a long time for this to get merged. Is it ok if I @ you once the PR goes through so we can merge this ASAP? I'm super sorry, I know I'm probably being crazy annoying with this PR lol
There was a problem hiding this comment.
yep all good. I usually get to these every weekend.
| "customKeycodes": [ | ||
| { | ||
| "name": "Cycle Layers", | ||
| "title": "Cycle through the layers (Place on same key on all layers)", | ||
| "shortName": "L_CYC" | ||
| } | ||
| ], |
There was a problem hiding this comment.
I dont see the custom keycodes in QMK?
Description
I'm a small keypad maker, The Mad Noodle , and I'm slowly working adding Via support for all of the keypads I've offered past and future.
This is for the Latest keypad, which I'm hopefully gonna be ready to launch in the coming few weeks!
So, I was trying to add this keypad to your repository/firmware list as soon as I could so I could link it directly in all of the setup guides that come with the purchased keypads since I plan to ship with the via keymap already installed.
AMENDMENT:
I've also added the Udon13 Keypad to this PR. I didn't know about the break the Via crew was taking for Jan - Feb, and while I've been waiting for the merge, The Udon:13 was successfully merged to the master branch of QMK as well. So, instead of opening another PR, I've just added it to this one. I hope that's alright!
I've tested everything on the keypads (firmware and design tab in Vias web app and desktop app), so all should be working perfectly :-)
QMK Pull Request
NoodlePad Micro: qmk/qmk_firmware#22703
Udon13: qmk/qmk_firmware#22704
Checklist
0xFEED