Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Petrichor to VIA #2227

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add Petrichor to VIA #2227

merged 1 commit into from
Jun 7, 2024

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Apr 3, 2024

Description

Add the Petrichor Keyboard to VIA
This handled both solderable and hotswap variants

QMK Pull Request

qmk/qmk_firmware#23413

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@awkannan
Copy link
Contributor Author

awkannan commented Apr 3, 2024

Note - created as draft and will mark ready for review when QMK firmware is in master

@awkannan awkannan marked this pull request as ready for review June 7, 2024 17:43
@awkannan
Copy link
Contributor Author

awkannan commented Jun 7, 2024

This was checked in -so I marked it as not draft. It's ready for review!

@Xelus22 Xelus22 merged commit 3bf7f63 into the-via:master Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants