[BugFix] Cleanup EventsOn listeners #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d up on unmount - `EventsOn` being outside of the useEffect was causing multiple listeners to be added and never cleaned up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes EventsOn being registered multiple times and never cleaned up.
🧠 Rationale behind the change
EventsOnbeing outside the useEffect hook was causing it to add another event listener every re-render. It should of been inside the hook so it only adds once and then gets cleaned up on unmountCommits & Changes:
AppFooter.tsxEventsOn("update-available")into useEffectApp.tsxEventsOn("new-day")into useEffect🏎 Quality check
Are there any erroneous console logs, debuggers or leftover code in your changes?
Walk away, take a break, re-read what you filled out above does it make sense if you were coming in cold? What extra context could you provide?