Skip to content

Commit

Permalink
add missing group element invariant checks
Browse files Browse the repository at this point in the history
The group element checks `secp256k1_{ge,gej}_verify` have first been
implemented and added in commit f202667
(PR bitcoin-core#1299). This commit adds additional verification calls in group
functions, to match the ones that were originally proposed in commit
09dbba5 of WIP-PR bitcoin-core#1032 (which is
obviously not rebased on bitcoin-core#1299 yet).

Also, for easier review, all functions handling group elements are
structured in the following wasy for easier review (idea suggested by
Tim Ruffing):

- on entry, verify all input ge, gej (and fe)
- empty line
- actual function body
- empty line
- on exit, verify all output ge, gej

Co-authored-by: Peter Dettman <peter.dettman@gmail.com>
Co-authored-by: Tim Ruffing <crypto@timruffing.de>
  • Loading branch information
3 people committed Jul 21, 2023
1 parent c545fdc commit 690b0fc
Showing 1 changed file with 82 additions and 20 deletions.
Loading

0 comments on commit 690b0fc

Please sign in to comment.