Fixes for NAT lgtm alerts (sonic-net#1320)

theasianpianist · Jun 17, 2020 · 0784502 · 0784502
1 parent 13fca3a
commit 0784502
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/cfgmgr/natmgr.cpp b/cfgmgr/natmgr.cpp
@@ -3936,7 +3936,7 @@ void NatMgr::setDynamicAllForwardOrAclbasedRules(const string &opCmd, const stri
         /* After deletion, set acl_interface to None */  
         if (opCmd == DELETE)
         {
-            m_natBindingInfo[dynamicKey].acl_interface == NONE_STRING;
+            m_natBindingInfo[dynamicKey].acl_interface = NONE_STRING;
         }
     }
 

diff --git a/natsyncd/natsync.cpp b/natsyncd/natsync.cpp
@@ -61,6 +61,14 @@ NatSync::NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *
     }
 }
 
+NatSync::~NatSync()
+{
+    if (m_AppRestartAssist)
+    {
+        delete m_AppRestartAssist;
+    }
+}
+
 /* To check the port init is done or not */
 bool NatSync::isPortInitDone(DBConnector *app_db)
 {

diff --git a/natsyncd/natsync.h b/natsyncd/natsync.h
@@ -43,6 +43,7 @@ class NatSync : public NetMsg
 {
 public:
     NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *stateDb, NfNetlink *nfnl);
+    ~NatSync();
 
     virtual void onMsg(int nlmsg_type, struct nl_object *obj);
 

diff --git a/tests/test_nat.py b/tests/test_nat.py
@@ -114,7 +114,7 @@ def test_DelNatStaticEntry(self, dvs, testlog):
         self.app_db.wait_for_n_keys("NAT_TABLE", 0)
 
         #check the entry is not there in asic db
-        keys = self.asic_db.wait_for_n_keys("ASIC_STATE:SAI_OBJECT_TYPE_NAT_ENTRY", 0)
+        self.asic_db.wait_for_n_keys("ASIC_STATE:SAI_OBJECT_TYPE_NAT_ENTRY", 0)
 
     def test_AddNaPtStaticEntry(self, dvs, testlog):
         # initialize