[syncd][Drop Counters] Check for string length before calling substr (s…

…onic-net#1456) * [orchagent][drop counter] Check for string length before calling substr
theasianpianist · Oct 2, 2020 · e4dfb37 · e4dfb37
1 parent 23be627
commit e4dfb37
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/orchagent/debug_counter/drop_counter.cpp b/orchagent/debug_counter/drop_counter.cpp
@@ -318,11 +318,21 @@ unordered_set<string> DropCounter::getSupportedDropReasons(sai_debug_counter_att
         if (drop_reason_type == SAI_DEBUG_COUNTER_ATTR_IN_DROP_REASON_LIST)
         {
             drop_reason = sai_serialize_ingress_drop_reason(static_cast<sai_in_drop_reason_t>(drop_reason_list.list[i]));
+            // in case of unsupported counter, enum value is returned as a str
+            if (drop_reason.length() < INGRESS_DROP_REASON_PREFIX_LENGTH)
+            {
+                continue;
+            }
             drop_reason = drop_reason.substr(INGRESS_DROP_REASON_PREFIX_LENGTH);
         }
         else
         {
             drop_reason = sai_serialize_egress_drop_reason(static_cast<sai_out_drop_reason_t>(drop_reason_list.list[i]));
+            // in case of unsupported counter, enum value is returned as a str
+            if (drop_reason.length() < EGRESS_DROP_REASON_PREFIX_LENGTH)
+            {
+                continue;
+            }
             drop_reason = drop_reason.substr(EGRESS_DROP_REASON_PREFIX_LENGTH);
         }