Jeremy/eng 997c past cancelled #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerminatorhits
changed the title
tc
reviewed
Mar 4, 2019
| ) : ( | ||
| <h5 className="small c-pointer font-weight-normal text-secondary mb-0">{label}</h5> | ||
| )} | ||
| <a href={href || '#'}> |
There was a problem hiding this comment.
can we move the onClick to the a tag instead of the Col tag?
|
we need a |
|
@tc done |
tc
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off of 997b, ideally review/merge it first: #222
Description
Why did you write this code?
don't show cancel button on
PastandCancelledtrip cardsadd user friendly cancel status text in red
How to Test
PastandCancelledWhich devices did you test on?
REVIEWERS:
Check against these principles:
High level
Does this code need to be written?
What are the alternatives?
Will this implementation become a support issue?
How much error margin does this solution have?
Code
Does the code follow industry standards?
JS: https://github.com/airbnb/javascript
React: https://github.com/airbnb/javascript/tree/master/react
https://github.com/vasanthk/react-bits
Documentation headers: http://usejsdoc.org/index.html
Is there duplicated code? Can it be refactored into a shared method?
Is the code consistent with our project?
Are there unit tests? Do they test the states?
Is the person refactoring another developer's code? If possible, did the original developer approve?
Variables/Naming:
Security
Further Work
Will this have future work?
Styling
Learnings
Did you learn anything here you want to share with the team?