Lay out /work/listings/:id #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like it's in a reasonable state to review. One thing worth noting is that the BookingBar will obscure part of the footer on tablet/mobile. This is actually the case for the old design, too, so this is at parity, but raising it in case anyone sees a solution |
kcvan
reviewed
Mar 2, 2019
src/pages/listing/ListingPage.tsx
Outdated
| <BookingCard {...listing} /> | ||
| </>); | ||
| const ListingPage = (listing: Listing) => ( | ||
| <> |
There was a problem hiding this comment.
ah thanks, was going to say this can be <Fade>
kcvan
approved these changes
Mar 2, 2019
tc
reviewed
Mar 4, 2019
| @@ -9,7 +9,7 @@ import BookingBar from './BookingBar'; | |||
| import { Listing } from 'networking/listings'; | |||
|
|
|||
| const ListingPage = (listing: Listing) => ( | |||
| <> | |||
| <Fade> | |||
There was a problem hiding this comment.
sometimes it's not good to use a Fade effect. I think it's fine here.
ie, if we want the page to load immediately, like the signup/booking pages. Anything slowing the user down to conversion is not good. cc @kcvan
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lay out the contents of the Listing page.
How to Test
Note that individual page elements are still unstyled (subsequent PRs!)
Which devices did you test on?
REVIEWERS:
Check against these principles:
High level
Does this code need to be written?
What are the alternatives?
Will this implementation become a support issue?
How much error margin does this solution have?
Code
Does the code follow industry standards?
JS: https://github.com/airbnb/javascript
React: https://github.com/airbnb/javascript/tree/master/react
https://github.com/vasanthk/react-bits
Documentation headers: http://usejsdoc.org/index.html
Is there duplicated code? Can it be refactored into a shared method?
Is the code consistent with our project?
Are there unit tests? Do they test the states?
Is the person refactoring another developer's code? If possible, did the original developer approve?
Variables/Naming:
Security
Further Work