Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload PDBs to the symbol server #7

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Upload PDBs to the symbol server #7

merged 9 commits into from
Feb 15, 2024

Conversation

sebmarchand
Copy link

Upload the sentry pdbs to the bcny symbol server

@sebmarchand sebmarchand requested a review from compnerd February 15, 2024 17:37
Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable other than the condition. This should be easy to verify pre-commit by just running the job.

@@ -100,3 +100,12 @@ jobs:
$pkgs = Get-ChildItem -Path io.sentry.sentry-native.crashpad.windows.*.nupkg
nuget push $pkgs[0].Name -Source ${env:NUGET_SOURCE_URL} -SkipDuplicate
shell: pwsh

- name: Upload PDBs to Azure
if: always()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be always? I don't see why this should run if a prior step failed.

@sebmarchand sebmarchand merged commit 9478484 into master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants