Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user test #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amedeedaboville
Copy link

@amedeedaboville amedeedaboville commented Mar 4, 2020

@capnfabs and I noticed this while doing #96 . On my machine (node v13)
it('should be able to update the users weekdays') test was failing:
it was returning '21' and expecting '12' as the updated days.
We noticed that the sort implementation in updateDays wasn't working to sort the days properly by having a>b twice (compare line 279 to 282) . Not sure if this is important elsewhere in the app but we fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant