Make picomatch an optional dependency #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging! Any chance you can cut a new release soon? |
|
Yes, I am on it. |
3 tasks
|
Hi, I'm blocked on getting this package into storybook until this PR is released. It looks like maybe you're working on converting to typescript, but perhaps you could release a patch version right now, and get new work into a subsequent release? That would really help us out, and it would also fix this package for anyone else using yarn pnp or pnpm. |
|
Yes, that's what I am going to do. Typescript will take a bit of time. |
|
Done @IanVS |
|
Thanks @thecodrr! I've updated my Storybook PR 🤞. |
|
Thank you for using fdir! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #76, this makes picomatch an optional peer dependency, to avoid it from being automatically installed by some package managers, or throwing warnings in others.
@thecodrr I'd love if you could take a look at this and hopefully merge and release a new version soon, so it can unblock me on storybookjs/storybook#19297 in adding this library to Storybook.