-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust CI #35
Add Rust CI #35
Conversation
Haha seems like I forgot to run |
The weird thing is when I run it locally it passes. Debugging github actions drives me crazy! You just have to push and see what happens. |
@sanders41 the test errors are more serious, but I don't see how we'd fix that because the sqlx Compile-time SQL checks are the biggest benefit of sqlx over anything in Python, so I'd love to keep that and not switch to using the |
This step sets everything up and is working locally, I'm trying to figure out why CI isn't happy with it. - name: Prep data # This prevents sqlx errors if the database isn't running
run: sh ./scripts/prep_tests.sh |
Yup, I also always hated debugging GitHub actions! It's among the worst developer experience one can see these days. |
For the format error it really was that the formatter needed running after I merged main. For Clippy and testing sqlx is definitely winning this battle so far 😄 . I've tried all kinds of things and so far nothing makes it happy. I'm stubborn though, I'm not giving up yet! |
FINALLY I got it to work. The last piece keeping things from working was I needed to create the scripts/data directory before copying the file. This was causing the docker startup to fail, but it didn't show up in the GH actions log. |
Nice! Glad it worked out after all that effort! Do you normally prune old branches in bulk or keep them for a few days? I just tend to keep things clean and have the fewest branches possible. |
Actually I usually turn on the setting that auto deletes the branches when they merge. I just forgot to delete this one. |
I wasn't aware there was such a setting 😂 And I was surprised someone so meticulous as you would keep unused branches lying around, I should have known there was a better way and just asked you! I'll activate that setting. |
No description provided.