Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switches to the configured display name for circle avatars #165

Merged

Conversation

gerbenjacobs
Copy link
Contributor

Switches the letter in the circle avatars (if not using custom avatars) to be taken from the configured display name (which is name by default)

Not only will this then match with the name of the author, it also prevents a bit of a privacy issue when the e-mailaddress first letter doesn't match with the author name.

In this merge request I also

  • added a space between all emoticons/images and text for readability
  • fixed a html error in the mail template

Change-Id: I5182e1c0664326ede089fa857dcb391edb20f088

Change-Id: I5182e1c0664326ede089fa857dcb391edb20f088
@marktopper marktopper merged commit fe0e417 into thedevdojo:master Jan 26, 2018
@marktopper
Copy link
Collaborator

Thanks 👍

@gerbenjacobs gerbenjacobs deleted the use-name-for-avatar-circles branch January 26, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants