selects the current category when creating a new discussion #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes thedevdojo#166 Change-Id: I57bdd8b4fe65e529a491e61a69acb969bee726eb
gerbenjacobs
commented
Jan 26, 2018
| @foreach($categories as $category) | ||
| @if(old('chatter_category_id') == $category->id) | ||
| <option value="{{ $category->id }}" selected>{{ $category->name }}</option> | ||
| @elseif(!empty($category_id) && $category_id == $category->id) |
There was a problem hiding this comment.
I had trouble with the mix of tabs and spaces in this file. So although it looks like it all changed, I only added the middle @elseif part.
It could technically be merged with the first if, since they both just add selected but I feel this is more readable. I.e. You either get selected because you match the old input data or you get selected because you're on a category page at the moment.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #166
Change-Id: I57bdd8b4fe65e529a491e61a69acb969bee726eb