Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add os_default_template to tests #116

Closed

Conversation

MarkusTeufelberger
Copy link

This module (and some others) don't seem to be tested by Travis.

@MarkusTeufelberger
Copy link
Author

As far as I understand your testing process, this should have failed because there are no recorded fixtures for this module yet, right?! O_o

@akofink
Copy link
Contributor

akofink commented Apr 4, 2018

Hmm... it does show 13 tests, up from 12. 🤷‍♂️

@MarkusTeufelberger
Copy link
Author

The thing is that I get an error locally when running this module:

AttributeError: 'OSDefaultTemplate' object has no attribute 'search' from

response = OSDefaultTemplate(operatingsystem=operatingsystem).search()

I wonder why it runs in Travis even though it has no Foreman server mocked up and also why it doesn't fail.

@akofink
Copy link
Contributor

akofink commented Apr 4, 2018

Oh! It's the inventory. You need to change the hosts: localhost part of os_default_template.yml to hosts: tests. Sorry, I'm a bit rusty at FAM tests. XD

@mdellweg
Copy link
Member

mdellweg commented Apr 4, 2018

I guess, this is a duplicate to #102 .
The 'search' problem will go away as soon as a new nailgun-release is out there (see SatelliteQE/nailgun#488)

@akofink
Copy link
Contributor

akofink commented Apr 5, 2018

Yeah, it's working for me locally (getting an expected VCR error). I was using an old version of Nailgun locally.

@mdellweg
Copy link
Member

With #102 merged, i think we can close this one.

@mdellweg mdellweg closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants