add support for copying activation keys #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean797
suggested changes
Aug 2, 2018
| organization = self.find_organization(organization) | ||
|
|
||
| kwargs = {'name': name, 'organization': organization} | ||
| activation_key = self._entities.ActivationKey(self._server, **kwargs) |
There was a problem hiding this comment.
I would rather find_activation_key was added to ansible_nailgun_cement.
|
|
||
| if len(response) == 1 and len(new_response) == 0: | ||
| if not self._module.check_mode: | ||
| new_activation_key = response[0].copy(data={'new_name': new_name}) |
There was a problem hiding this comment.
I think adding an elif state == 'copied': to
| organization=dict(required=True), | ||
| lifecycle_environment=dict(), | ||
| content_view=dict(), | ||
| subscriptions=dict(type='list'), | ||
| auto_attach=dict(type='bool', default=True), | ||
| state=dict(default='present', choices=['present', 'copied']), | ||
| ), | ||
| supports_check_mode=True, |
There was a problem hiding this comment.
Adding required_if would be useful for new_name & state == copied
|
@sean797 I agree that this module needs some |
sean797
reviewed
Aug 6, 2018
modules/katello_activation_key.py
Outdated
| @@ -210,13 +239,18 @@ def main(): | |||
| password=dict(required=True, no_log=True), | |||
| verify_ssl=dict(type='bool', default=True), | |||
| name=dict(required=True), | |||
| new_name=dict(required=False), | |||
There was a problem hiding this comment.
nitpick, we don't normally include required=False because it's the default.
sean797
approved these changes
Aug 6, 2018
|
@sean797 added some simple test, which will at the moment fail, as the code requires git master of nailgun |
|
💚 |
evgeni
commented
Aug 6, 2018
test/inventory/hosts
Outdated
| @@ -1,3 +1,3 @@ | |||
| localhost ansible_connection=local ansible_python_interpreter=../ansible_fail.py | |||
| #localhost ansible_connection=local ansible_python_interpreter=../ansible_fail.py | |||
There was a problem hiding this comment.
damn, that was not supposed to be here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on SatelliteQE/nailgun#517 and still needs tests