Added location role #1623
Merged
Added location role #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Thanks Alan! And sorry it took so long to get this reviewed!
Overall, this looks good. I posted two comments inline, but nothing major.
One thing that is missing right now are tests. Given our test suite is a bit involved, I can understand if you say that you'd prefer not to touch even more things right now (and would offer you to just do the tests for you), or, if you want of course, you could try to write tests and I'll help you getting there? Absolutely up to you.
roles/locations/README.md
Outdated
| theforeman.foreman.locations | ||
| =================================== | ||
|
|
||
| This role creates and manages Satellite locations. |
There was a problem hiding this comment.
Suggested change
| This role creates and manages Satellite locations. | |
| This role creates and manages Foreman locations. |
(the branding happens automatically, here we keep the Foreman name)
|
I have made the requested changes, and added the test playbook named locations_role.yml. Please review! |
evgeni
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a location role which loops through a list of locations foreman_locations and creates them on Satellite server using the foreman location module.