Enable override: false for smart class parameters #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @yuqo2450 ! I've added a trivial changelog entry and otherwise your code change looks good. |
|
Thanks for answering that fast. It's not to big of a change though 😉! |
|
probably, but a good find nonetheless! I've now added a simple test for this, so we don't regress here, and will merge once CI is green. |
evgeni
approved these changes
Jul 26, 2023
…de is set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the smart_class_parameter plugin, to address issue #1644.
Enforcing the
parameter_typeto beNoneinstead of empty string ,allows to set a smart class parameter tofalse.Was tested locally with
Foreman 3.2.1.