don't fail when removing a content credential from a repository

[evgeni]

No description provided.

[evgeni]

probably should add tests, right? 🙈

[evgeni]

and the tests say I am stupid…

and the tests helped me to write the fix correctly

[evgeni]

Mhh. The existing apidoc doesn't have https://projects.theforeman.org/issues/36497 yet. Makes sense.

[evgeni]

@ehelms @mdellweg @Griffin-Sullivan does anyone want to look at this one? 🥺

[Griffin-Sullivan]

LGTM. Is the /fixtures directory what we use for "recorded" testing?

[evgeni]

LGTM. Is the /fixtures directory what we use for "recorded" testing?

Yes, exactly.

[ehelms]

This is a in two-three releases of Katello this work around gets dropped?

[evgeni]

We've been rather conservative in dropping those apidoc patches, but the code is a noop once it detects a new enough version.

foreman-ansible-modules/plugins/module_utils/foreman_helper.py

Lines 109 to 135 in 87e1b51

	def _check_patch_needed(introduced_version=None, fixed_version=None, plugins=None):
	"""
	Decorator to check whether a specific apidoc patch is required.
	:param introduced_version: The version of Foreman the API bug was introduced.
	:type introduced_version: str, optional
	:param fixed_version: The version of Foreman the API bug was fixed.
	:type fixed_version: str, optional
	:param plugins: Which plugins are required for this patch.
	:type plugins: list, optional
	"""
	def decor(f):
	@wraps(f)
	def inner(self, *args, **kwargs):
	if plugins is not None and not all(self.has_plugin(plugin) for plugin in plugins):
	return
	if fixed_version is not None and self.foreman_version >= LooseVersion(fixed_version):
	return
	if introduced_version is not None and self.foreman_version < LooseVersion(introduced_version):
	return
	return f(self, *args, **kwargs)
	return inner
	return decor