Fixes #28697: Add Postgres upgrade to Foreman scenario #444
Conversation
|
This is designed to run Postgres upgrade in all situations where Foreman is present and its RHEL 7 regardless of upgrade parameter. |
ehelms
force-pushed
the
fixes-28697
branch
2 times, most recently
from
d4a8882
to
e7d9719
Compare
ehelms
force-pushed
the
fixes-28697
branch
2 times, most recently
from
dac15ad
to
be15446
Compare
hooks/pre/30-upgrade_postgresql.rb
Outdated
| def postgresql_10_upgrade | ||
| execute('foreman-maintain service start --only=postgresql') | ||
| (name, owner, enconding, collate, ctype, privileges) = %x{runuser postgres -c 'psql -lt | grep -E "^\s+postgres"'}.chomp.split('|').map(&:strip) | ||
| execute('foreman-maintain service stop') |
There was a problem hiding this comment.
Checking, @ekohl are you OK with this being here with a requirement on RPM foreman-installer packaging to require foreman-maintain? This code is gated on el7? so Debian is unaffected.
There was a problem hiding this comment.
While I'm not Ewoud, I'd be OK with that. But I think I'd prefer the file to be called 30-el7_upgrade_postgresql to denote it's only relevant on el7.
|
Files renamed |
ehelms
force-pushed
the
fixes-28697
branch
3 times, most recently
from
e801135
to
918b674
Compare
|
Welp, this happened http://mirror.centos.org/centos/7/sclo/x86_64/rh/rh-postgresql12/ so I suppose I'll go and test that in case I can just change this to that. |
|
Yeah, it'd be cool if we can go straight to 12 with 2.0 |
| @@ -40,6 +40,10 @@ def local_redis? | |||
| (foreman_server? && !param_value('foreman', 'jobs_sidekiq_redis_url')) || param_value('foreman_proxy::plugin::pulp', 'pulpcore_enabled') | |||
| end | |||
|
|
|||
| def needs_postgresql_scl_upgrade? | |||
| !File.exist?('/var/opt/rh/rh-postgresql12/lib/pgsql/data') && File.exist?('/var/lib/pgsql/data') | |||
There was a problem hiding this comment.
@evgeni I had to add a condition here for this to work on fresh installations. Before adding the && part, it attempted an upgrade on a fresh install.
There was a problem hiding this comment.
Makes sense.
This will still try to upgrade if the user installed postgres before running the installer, but I think that's fine as being labeled "unsupported"?
|
This has been updated instead to PostgreSQL 12. @tbrisker for your awareness that we'd be switching to PG 12 instead of 10 now that it's published (http://mirror.centos.org/centos/7/sclo/x86_64/rh/rh-postgresql12/). Bats tests passed for me. This scratch build can be used to test: http://koji.katello.org/koji/taskinfo?taskID=272814 |
|
My testing of this with Pulp 3 yielded no errors. |
|
I am not merging this in case you first want to fix Katello nightly pipelines. |
|
Niightly is greeeen. This will, however, need theforeman/foreman-packaging#4577 resolved as well to not fail on nightly tests. |
No description provided.