Set external core to true for EL-based distributions

theforeman · Jun 11, 2019 · 075d5f3 · 075d5f3
1 parent 58ab572
commit 075d5f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/manifests/plugin/dynflow/params.pp b/manifests/plugin/dynflow/params.pp
@@ -10,5 +10,8 @@
   $ssl_disabled_ciphers  = undef
   $tls_disabled_versions = undef
   $open_file_limit       = 1000000
-  $external_core         = undef
+  $external_core         = $facts['osfamily'] ? {
+    'RedHat' => true,
+    default  => undef
+  }
 }
diff --git a/spec/classes/foreman_proxy__plugin__dynflow_spec.rb b/spec/classes/foreman_proxy__plugin__dynflow_spec.rb
@@ -27,12 +27,16 @@
         it { should contain_foreman_proxy__plugin('dynflow') }
 
         it 'should generate correct dynflow.yml' do
-          verify_exact_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/dynflow.yml", [
+          lines = [
             '---',
             ':enabled: https',
             ':database: ',
             ':core_url: https://foo.example.com:8008',
-          ])
+          ]
+          lines << ':external_core: true' if has_core
+          verify_exact_contents(catalogue,
+                                "#{etc_dir}/foreman-proxy/settings.d/dynflow.yml",
+                                lines)
         end
 
         if has_core
@@ -78,7 +82,7 @@
           :ssl_disabled_ciphers  => ['NULL-MD5', 'NULL-SHA'],
           :tls_disabled_versions => ['1.1'],
           :open_file_limit       => 8000,
-          :external_core         => true,
+          :external_core         => false,
         } end
 
         it { should compile.with_all_deps }
@@ -118,7 +122,7 @@
               ':enabled: https',
               ':database: /var/lib/foreman-proxy/dynflow/dynflow.sqlite',
               ':core_url: https://foo.example.com:8008',
-              ':external_core: true',
+              ':external_core: false',
             ])
           end
         else