Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pulp3 naming be pulpcore? #550

Closed
ehelms opened this issue Dec 6, 2019 · 2 comments · Fixed by #556
Closed

Should pulp3 naming be pulpcore? #550

ehelms opened this issue Dec 6, 2019 · 2 comments · Fixed by #556
Labels
skip-changelog

Comments

@ehelms
Copy link
Member

ehelms commented Dec 6, 2019

We now have a mixed use of conventions with naming some things pulp3 and others pulpcore.

  • Should we settle on a single convention?
  • Does any scenario make sense to be Pulp 3?
  • Is this an installer / module only issue or also something the smart proxy plugin should account for?

@jlsherrill your thoughts would be appreciated
@ekohl
Copy link
Member

ekohl commented Dec 6, 2019

IMHO the installer should follow the smart proxy plugin. We've kept that convention everywhere and makes it straight forward to know an installer option reflects a plugin option.

@jlsherrill
Copy link
Contributor

I think it makes sense to standardize on pulpcore, so my vote would be to standardize on pulpcore parameters, and then at some point, update the smartproxy plugin to use 'pulpcore'.

I'm happy to take the work on updating the smartproxy plugin (and katello changes) now.

wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 6, 2020
@wbclark
use pulpcore naming convention
6fd3348 
solves theforeman#550
@wbclark wbclark mentioned this issue Jan 6, 2020
Merged
wbclark added a commit to wbclark/puppet-foreman_proxy_content that referenced this issue Jan 6, 2020
@wbclark
use pulpcore naming convention
7be9bc1 
this will require theforeman/puppet-foreman_proxy#556

solves theforeman/puppet-foreman_proxy#550
@wbclark wbclark mentioned this issue Jan 6, 2020
Merged
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 7, 2020
@wbclark
use pulpcore naming convention
eca362a 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 7, 2020
@wbclark
use pulpcore naming convention
7ed6d90 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 7, 2020
@wbclark
use pulpcore naming convention
8b774b5 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
705428f 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
3fe98e7 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
0c87ff2 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
5429ca9 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
1436247 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
49c91b5 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
af37b82 
solves theforeman#550
wbclark added a commit to wbclark/puppet-foreman_proxy that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
9a2561e 
solves theforeman#550
ehelms pushed a commit that referenced this issue Jan 8, 2020
@wbclark @ehelms
use pulpcore naming convention
eb3ad13 
solves #550
wbclark added a commit to wbclark/puppet-foreman_proxy_content that referenced this issue Jan 8, 2020
@wbclark
use pulpcore naming convention
ca62ce6 
fixes theforeman/puppet-foreman_proxy#550
ehelms pushed a commit to theforeman/puppet-foreman_proxy_content that referenced this issue Jan 9, 2020
@wbclark @ehelms
use pulpcore naming convention
0894d60 
fixes theforeman/puppet-foreman_proxy#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use pulpcore naming convention wbclark/puppet-foreman_proxy
3 participants
@ekohl @ehelms @jlsherrill