Refs #24012 - Add PuppetCA providers settings #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Jun 26, 2018
|
Thanks! |
alexjfisher
reviewed
Jan 11, 2019
| @@ -9,12 +9,23 @@ Part of the Foreman installer: <https://github.com/theforeman/foreman-installer> | |||
|
|
|||
| | Module version | Proxy versions | Notes | | |||
| |----------------|----------------|-------------------------------------------------| | |||
| | 5.x | 1.16 and newer | | | |||
| | 5.x | 1.16 and newer | See compatibility notes here for 1.16-1.18 | | |||
There was a problem hiding this comment.
@ekohl Version 5? What about 6,7,8 and 9?
There was a problem hiding this comment.
This should be 5.x and newer. The breaking changes have been for different reasons than compatibility. Untested, but I think 9 should still allow managing 1.16. It'd be good to be explicit about this though.
alexjfisher
reviewed
Jan 11, 2019
| | 4.x | 1.12 - 1.17 | See compatibility notes in its README for 1.15+ | | ||
| | 3.x | 1.11 | | | ||
| | 2.x | 1.5 - 1.10 | | | ||
| | 1.x | 1.4 and older | | | ||
|
|
||
| ### Compatibility notes for Smart Proxy < 1.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the settings for the
puppetca_hostname_whitelistingprovider for the new modular PuppetCa module. This should fix the current nightlies.This is a part of #433 but without the
token_whitelistingprovider's settings and with the suggested additions.This is a working copy of #434 because I sometimes am unable to work with git properly. See previous commit.