fixes #24653 - only use grub mkimage on RHEL 7.4 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
force-pushed
the
24653
branch
2 times, most recently
from
021c8f8
to
e57e637
Compare
ekohl
reviewed
Aug 24, 2018
|
@stbenjam could you have a look? |
We previously enabled a workaround that breaks secureboot, as using mkimage to build the EFI grub images results in an unsigned image. We should only do this on 7.4, as the mac address issue is fixed in 7.5 and later.
ekohl
approved these changes
Nov 20, 2018
|
merged, thanks @stbenjam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously enabled a workaround that breaks secureboot, as using
mkimage to build the EFI grub images results in an unsigned image. We
should only do this on 7.4, as the mac address issue is fixed in 7.5 and
later.