Fixes #25036 - ensure proxy registration happens before puppet #456
Conversation
|
@evgeni, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
|
failures seem unrelated |
manifests/register.pp
Outdated
| # Ensure the service is started after registering the Foreman proxy | ||
| # Relationship is duplicated there as defined() is parse-order dependent | ||
| if defined(Class['puppet::agent::service']) { | ||
| Foreman_smartproxy[$foreman_proxy::registered_name] -> Class['puppet::agent::service'] |
There was a problem hiding this comment.
If you rewrite this to -> Class <| title == 'puppet::agent::service' |> I believe you don't need the defined and it's no longer parse-order dependent.
There was a problem hiding this comment.
There was a problem hiding this comment.
but you can:
Foreman_smartproxy[$foreman_proxy::registered_name] -> Cron <| title == 'puppet' |>
Foreman_smartproxy[$foreman_proxy::registered_name] -> Service <| title == 'puppet' |>
Foreman_smartproxy[$foreman_proxy::registered_name] -> Service <| title == 'puppet-run.timer' |>There was a problem hiding this comment.
Seems to have worked in my test setup.
|
@evgeni pelase rebase |
|
@mmoll rebase on what? this is based on |
|
Hrm, I thought the beakers tests work now, but it seems we would need to release some of our modules.... testing locally now |
|
merged, cпасибо @evgeni! |
No description provided.